fix(README): remove tags hiding end of the content #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the `details` and `summary` HTML tags used to wrap `./test/negative-tests/for-mdx/mdx_cases.ml.corrected.expected`'s `part=matching` that were hiding the end of `README.mdx`. PS: I don't know much about MDX, so I'm not sure if this is even a "fix" or the best way to fix it. If you have a better solution, go for it! Signed-off-by: GitFenixZ <[email protected]>
GitFenixZ
force-pushed
the
fix-readme-hidden-content
branch
from
b19b7b9 to
b2205a6
Compare
github-iron
added
the
forwarded-to-js-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the
detailsandsummaryHTML tags used to wrap./test/negative-tests/for-mdx/mdx_cases.ml.corrected.expected'spart=matchingthat were hiding the end ofREADME.mdxand breaking the code block.This is how
README.mdxlooks without this PR.To see how it looks with this PR:
https://github.com/GitFenixZ/ppx_expect/tree/fix-readme-hidden-content
PS: I don't know much about MDX, so I'm not sure if this is even a "fix" or the best way to fix it. If you have a better solution, go for it!