Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1420 Fader Settings improvements #3138

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Aug 1, 2023

Short description of changes

Two changes relating to #1420:

  • Edit -> Set All Faders to New Client Level
    This retained the last known level for any client, so when that client rejoined the server, their old level was restored
    image
    This has been reworded to make its behaviour clear
    image
    "Set Current Faders to New Client Level" will be the behaviour that is intended - it will not take any stored fader levels into account. (Of course, these fader levels will then apply should a "current" client leave and rejoin.)

  • Edit -> Stored Fader Settings
    This new sub-menu replaces "Clear All Stored Solo and Mute Settings" and finer-grained control, including allowing all settings to be purged:
    image
    image

CHANGELOG: Client: Fader Settings improvements

Context: Fixes an issue?

Fixes: -1420

Does this change need documentation? What needs to be documented and how?

Yes!

  • App translations are affected
  • Site documentation is affected

Status of this Pull Request

It runs and looks okay. I don't generally worry about stored fader settings, so I've not got much to test on. It could do with several people who use the feature heavily looking at it.

@pgScorpio, hopefully this is what you were after.

What is missing until this pull request can be merged?

  • Code review.
  • More testing by people who use the feature.
  • Usability feedback.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Sorry, something went wrong.

@pljones pljones added this to the Release 3.11.0 milestone Aug 1, 2023
@pljones pljones self-assigned this Aug 1, 2023
@pljones pljones force-pushed the bugfix/1420-rework-storedfader-settings branch from 80c4511 to a5723c0 Compare August 3, 2023 18:58

Verified

This commit was signed with the committer’s verified signature. The key has expired.
pljones Peter L Jones
@pljones pljones force-pushed the bugfix/1420-rework-storedfader-settings branch from a5723c0 to 32133cf Compare August 15, 2023 16:28
@pljones pljones closed this Aug 23, 2023
@pljones pljones deleted the bugfix/1420-rework-storedfader-settings branch August 23, 2023 09:49
@pljones pljones removed this from the Release 3.11.0 milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant