Simplify device driver error message

[ann0see]

Short description of changes

Split out from #2168

Re-submitting since the other PR seemed to contained too much different code changes (added ASIO driver Setup button, which could be part of another PR.

CHANGELOG: Simplify device driver error message on Windows by removing unneeded HTML

Context: Fixes an issue?

No. But it should make the error message more readable.
Does this change need documentation? What needs to be documented and how?
I doubt it.

Status of this Pull Request

PoC, still open for improvements.

What is missing until this pull request can be merged?

Test on Windows, Review

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[ann0see]

Ok. See the screenshot of the message:

[ann0see]

@gilgongo could you please Review?

[pljones]

Ok. See the screenshot of the message:

Hm. That screenshot looks confusing. I get the same error message twice, once for each driver, and then I'm asked if I want to open "driver settings". Which driver? Do both get opened? That'll be pretty confusing...

[ann0see]

That’s an issue with the initial (internal) error message. It would have been the same before this PR, so it’s worth changing it elsewhere (@pgScorpio maybe your change can also solve this confusing error handling)

[pgScorpio]

That’s an issue with the initial (internal) error message. It would have been the same before this PR, so it’s worth changing it elsewhere (@pgScorpio maybe your change can also solve this confusing error handling)

Yes give my new sound implementation a try.

All sound related error messages, whatsthis- tooltip- and other sound related texts now come from CSoundbase and can be defined in the CSound implementation.

It also solves various other issues, like not being able to change the settings of the 'skipped' drivers.

[ann0see]

@gilgongo @pljones could you please re-review?

[gilgongo]

I think the wording's OK, but I'm not sure how it's being presented - are we still showing a warning for each driver (as in #2496 (comment))?

[ann0see]

Yes. There's nothing I can do about the presentation at the moment. That's what the sound redesign will hopefully handle.

[gilgongo]

OK sure. Well the wording is certainly improved, so that's cool.

[ann0see]

@gilgongo I've now rebased this PR.