Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Render Button Right #190

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZHamburglar
Copy link

No description provided.

Copy link
Owner

@jakezatecky jakezatecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ZHamburglar and thank you for the PR!

I have reviewed the changes and have run the examples. Everything seems to be fine. However, this PR adds a lot of additional changes to the code base when I think this display change could best be implemented in a user's code.

For example, I think the following CSS-related changes would achieve the same thing this PR accomplishes:

.rct-collapse {
  order: 1;
  margin-left: auto;
}

Would such a CSS change be usable under your use case? The reason I ask is because there are a lot of properties and tested elements already in this library and I want to reduce maintenance burden when some things can be done by users of the library with minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants