This repository has been archived by the owner on May 18, 2020. It is now read-only.
fix(all-in-one): support for Kubernetes v1.16+ #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subnetmarco thanks for the PR. To merge this we should probably bump the minikube version to pass the CI. Also the commits have to be signed (DCO). |
|
@subnetmarco could you also apply the same fix to the production template? |
|
@objectiser done with my last commit ca16ed2 |
|
Hi @subnetmarco can you also address the points raised by Pavol in #132 (comment) |
…es v1.16+ Signed-off-by: subnetmarco <[email protected]>
Signed-off-by: subnetmarco <[email protected]>
Signed-off-by: subnetmarco <[email protected]>
Signed-off-by: subnetmarco <[email protected]>
Signed-off-by: subnetmarco <[email protected]>
|
We are going to deprecate the repository. Please have a look at https://github.com/jaegertracing/jaeger-operator/#experimental-generate-kubernetes-manifest-file and share your feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extensions/v1beta1API version is deprecated and no longer supported in Kubernetes v1.16+ and fails with the following error:This PR makes the
jaeger-all-in-one-template.ymlcompatible with newer version of Kubernetes.