Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Stop button to the controls #908

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daredoes
Copy link
Contributor

@daredoes daredoes commented Jun 2, 2023

Super small PR that was made easy by all the existing features and work!

Fixes #434

Screenshot 2023-06-01 at 7 04 45 PM Screenshot 2023-06-01 at 7 04 36 PM

@jaedb
Copy link
Owner

jaedb commented Jun 4, 2023

Nice work. I would suggest the stop button is grouped with the other playback controls, rather than the mode and output controls.

A good fit would be between the Play and Next icons. A few things you will need to check is how it stacks on the various screen sizes and responsive breakpoints. To get a feel for the default breakpoints, see https://github.com/jaedb/Iris/blob/master/src/scss/global/_variables.scss#L1-L6 but note this can vary with pixel density and per-component.

@daredoes
Copy link
Contributor Author

daredoes commented Jun 4, 2023

@jaedb The layout for the play/pause/next/previous icons is so smooth is just felt wrong to place it with them. Putting it with the other small feature icons felt more appropriate.

Maybe we can re-arrange the mode and output controls so it goes (Shuffle, Loop, Stop, Consume, Output) as to keep the shuffle and loop as close to the playback bar as possible?

Ultimately, your the creator and I will do as you suggest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit stop button
2 participants