Add support for custom JSON marshal and unmarshal #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitar
commented
May 13, 2024
pgtype/json_test.go
Outdated
| } | ||
|
|
||
| pgxtest.RunValueRoundTripTests(context.Background(), t, connTestRunner, pgxtest.KnownOIDQueryExecModes, "json", []pgxtest.ValueRoundTripTest{ | ||
| {[]byte(`"hello"`), new(string), isExpectedEq(`{"custom":"value"}`)}, |
There was a problem hiding this comment.
@jackc I do not know how to write this test. This does not work. It seems like Marshal is simply not called? Any insight? Maybe I should not use RunValueRoundTripTests?
|
func (c JSONCodec) PlanEncode(m *Map, oid uint32, format int16, value any) EncodePlan {
switch value.(type) {
case string:
return encodePlanJSONCodecEitherFormatString{}
case []byte:
return encodePlanJSONCodecEitherFormatByteSlice{}You probably want to test something like a |
|
@jackc Thanks! This is ready for review now I think. |
The Codec interface is now implemented by *pgtype.JSONCodec and *pgtype.JSONBCodec instead of pgtype.JSONCodec and pgtype.JSONBCodec, respectively. This is technically a breaking change, but it is extremely unlikely that anyone is depending on this, and if there is downstream breakage it is trivial to fix. Fixes jackc#2005.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2005.