Support really large objects #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b99e2bb.
mitar
commented
Jan 14, 2024
|
The large object tests should not be parallel anymore with the changes to the global variable |
|
The implementation itself is fine as far as I can tell. |
I was thinking about that, but they are all set to the same value. So does it really matter for the purpose of tests? |
mitar
force-pushed
the
really-large-objects
branch
from
f3c601a
to
354efd1
Compare
mitar
force-pushed
the
really-large-objects
branch
from
354efd1
to
e4cc563
Compare
|
I updated PR and I think it is ready for review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1865.