Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Acl support #104

Open
wants to merge 7 commits into
base: 1.x
Choose a base branch
from
Open

[WIP] Acl support #104

wants to merge 7 commits into from

Conversation

lsmith77
Copy link
Member

needs the following to be added to the <workspace> tag in the repository.xml:

        <Import>
          <ProtectedNodeImporter
class="org.apache.jackrabbit.core.xml.AccessControlImporter"/>
          <ProtectedPropertyImporter
class="org.apache.jackrabbit.core.security.user.UserImporter">
             <param name="importBehavior" value="besteffort"/>
          </ProtectedPropertyImporter>
        </Import>

requires jackalope/jackalope#274 and phpcr/phpcr-api-tests#152

TODO

  • [] Figure out getSupportedPrivileges vs privilegeFromName. flat list of privileges or only jcr:all with nested?

@@ -21,14 +21,14 @@
"ext-curl":"*",
"phpcr/phpcr": "~2.1.2",
"phpcr/phpcr-utils": "~1.1",
"jackalope/jackalope": "~1.2.0"
"jackalope/jackalope": "dev-acl"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be changed to the final version

@@ -0,0 +1,108 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample privileges response. needs to be removed again

@evert
Copy link

evert commented Feb 10, 2015

Crazy how much this looks like WebDAV / RFC3744

@lsmith77
Copy link
Member Author

@evert this is Davex, which is based on Webdav .. infact Jackrabbit is also a Webdav server .. kind of cool huh? a content repository where a graphic designer could mount a path via webdav, mess with images there and write it back into the repo without ever touching a web interface. there is a reason Adobe bought a Jackrabbit based CMS.

@evert
Copy link

evert commented Feb 10, 2015

Huh! I should look into that more... Is there value in adding sabredav as a frontend for jackalope for you? Or does that not make sense.

@lsmith77
Copy link
Member Author

@evert for the Jackrabbit integration we rather need a webdav client .. however at some point we might want to also provide a webdav interface for jackalope-doctrine-dbal

@dbu
Copy link
Member

dbu commented Feb 11, 2015

not sure if you would want to build on phpcr for that. maybe the thing would be a sabredev frontend for flysystem (which has a phpcr adapter for storage).

@evert
Copy link

evert commented Feb 11, 2015

flysystem would give a very weak version of your underlying data-model, only representing files and directories and basic FS operations.

With a full-blown webdav frontend, you actually get an API that allows you to query and modify properties, express/enforce/mutate ACL rules, etc.

Anyway.. could be a fun side project for me at one point :)

Sorry for hijacking this thread!

@dbu
Copy link
Member

dbu commented Feb 11, 2015

@evert well, jackrabbit itself only allows webdav for nodes that represent folders or files, afaik. arbitrary nodes with properties are not a concept webdav understands. but i certainly won't stop you if you want to give things a try. i suggest you open an issue on the phpcr repository when you are ready to hack on this, for further discussion. just make sure to write against the PHPCR interfaces, and not limit yourself to a concrete implementation like jackalope-jackrabbit.

@evert
Copy link

evert commented Feb 11, 2015

That's definitely not true! webdav certainly supports any type of node :) we have many non-file nodes, such as principal nodes that have no mapping to a GET request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants