Fix/double color #17
Open
Fix/double color #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: removed cell color as the color is already applied on the cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixing a problem where colors were applied twice, making it slightly off from the expected color.
As the UIImages are already colored by the
UIImage.coloredfunction, there is no need to also apply the same color to theCAEmitterCell. Doing this applies the same color twice.This removes the color from the emitter cell, although another solution could be painting the
UIImagewhite and applying the correct color to theCAEmitterCell.Screenshot
Before and After screenshots of this change. As shown the pastel colors are slightly darker on the confetti than the colors shown in the view. They use the exact same color, but because of the double appliance, they turn out darker.
Checklist
Swift Package ManagerandCocoapods