UI improvements #34
Merged
UI improvements #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/ui-improvements
branch
from
deec2c1 to
541cbb7
Compare
yepzdk
approved these changes
Dec 16, 2024
assets/admin.js
Outdated
| // Open accordions with errors on submit. | ||
| document.addEventListener("ea.form.error", (event) => { | ||
| const { page, form } = event.detail; | ||
| // alert(`The ${page} form contains errors. Please resolve these before submitting again.`) |
There was a problem hiding this comment.
No, it's a leftover from testing example code in EasyCorp/EasyAdminBundle#6650. I've removed the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/TimeTable/TimeTable?showTicketModal=3248#/tickets/showTicket/3248
Description
Please include a short description of the suggested change and the reasoning behind the approach you have chosen.
Screenshot of the result
If your change affects the user interface you should include a screenshot of the result with the pull request.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.
Additional comments or questions
If you have any further comments or questions for the reviewer please add them here.