Build and use our image in CI. #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfabio
force-pushed
the
circleci
branch
6 times, most recently
from
8bec349
to
2bc195d
Compare
Build the Docker image and use it in CI to run tests and build the site. Also upload it to DockerHub.
sebbalex
reviewed
Oct 12, 2020
| @@ -25,7 +25,7 @@ | |||
| "scripts": { | |||
| "build": "webpack --config webpack.prod.js", | |||
| "lint": "npx eslint _site/ --ext .json", | |||
| "deploy": "gh-pages -u 'Deploy Bot <[email protected]>' -d _site" | |||
| "deploy": "npx gh-pages -u 'Deploy Bot <[email protected]>' -d _site" | |||
There was a problem hiding this comment.
+1 we can even remove it from dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for Hacktoberfest end to refine and merge, in order to avoid breaking something for the newcomers.
Fix #691.