-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RemoveDuplicateVertices Implementation for TriangleMesh (continued) #6636
Open
shashigk
wants to merge
9
commits into
isl-org:main
Choose a base branch
from
shashigk:sganjugu/remdup2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 6, 2023
-
RemoveDuplicateVertices Implementation for TriangleMesh.
Functionality to remove duplicate vertices and update other vertex attributes and triangle indices is implemented. The C++ and python tests are also written to test the code. On branch sganjugu/remdup2 Changes to be committed: modified: cpp/open3d/t/geometry/TriangleMesh.cpp modified: cpp/open3d/t/geometry/TriangleMesh.h modified: cpp/pybind/t/geometry/trianglemesh.cpp modified: cpp/tests/t/geometry/TriangleMesh.cpp modified: python/test/t/geometry/test_trianglemesh.py
Configuration menu - View commit details
-
Copy full SHA for 4535bb2 - Browse repository at this point
Copy the full SHA 4535bb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b56ca5f - Browse repository at this point
Copy the full SHA b56ca5fView commit details
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 158d965 - Browse repository at this point
Copy the full SHA 158d965View commit details
Commits on Nov 15, 2023
-
Duplicate vertex attributes shrunk using IndexGet
Previously, I was doing a manual copy and shrinking the vertices. Instead in this checkin all vertex attributes, including the coordinates are shrunk using IndexGet method using a vertex mask. Further, the triangle index remapping is similar to what was done earlier, with some simplications. One thing to note, is that we cannot use utility::InclusivePrefixSum to remap vertex indices because the duplicates can occur in any position and may be duplicates of any earlier vertex. For e.g., suppose there were 9 vertices to start with, and 8th (index 7, starting from 0), was a duplicate of 2nd (index 1, starting from 0). So, the vertex mask would look like this: Vertex indices: [0, 1, 2, 3, 4, 5, 6, 7, 8] Vertex mask: [1, 1, 1, 1, 1, 1, 1, 0, 1] Prefix sum: [0, 1, 2, 3, 4, 5, 6, 7, 7, 8] This gives an incorrect index map for 8th vertex, which is mapped to index 7 instead of 1. On branch sganjugu/remdup2 Your branch is up to date with 'origin/sganjugu/remdup2'. Changes to be committed: modified: ../cpp/open3d/t/geometry/TriangleMesh.cpp modified: ../python/test/t/geometry/test_trianglemesh.py
Configuration menu - View commit details
-
Copy full SHA for a7664c8 - Browse repository at this point
Copy the full SHA a7664c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9155acf - Browse repository at this point
Copy the full SHA 9155acfView commit details
Commits on Feb 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f4bcc48 - Browse repository at this point
Copy the full SHA f4bcc48View commit details
Commits on Feb 4, 2024
-
Fixed vertex mask and handle case of triangle indices being absent.
- Made vertex mask type bool. - Check if mesh has triangle indices before getting them. - Modified some errors to warnings. On branch sganjugu/remdup2 Your branch is up to date with 'origin/sganjugu/remdup2'. Changes to be committed: modified: cpp/open3d/t/geometry/TriangleMesh.cpp
Configuration menu - View commit details
-
Copy full SHA for cbf75f8 - Browse repository at this point
Copy the full SHA cbf75f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for db3f353 - Browse repository at this point
Copy the full SHA db3f353View commit details -
Used DISPATCH_FLOAT_INT_DTYPE_TO_TEMPLATE macro.
Instead of using if statements explicitly, used DISPATCH_FLOAT_INT_DTYPE_TO_TEMPLATE to dispatch to RemoveDuplicateVerticesWorker function appropriately. On branch sganjugu/remdup2 Your branch is up to date with 'origin/sganjugu/remdup2'. Changes to be committed: modified: ../cpp/open3d/t/geometry/TriangleMesh.cpp
Configuration menu - View commit details
-
Copy full SHA for b98ace5 - Browse repository at this point
Copy the full SHA b98ace5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.