This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
feat: not finish #90
Merged
feat: not finish #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khajornritdacha
suggested changes
Aug 3, 2023
Comment on lines
+7
to
+16
| <GameContainer | ||
| scene={{ | ||
| id: page, | ||
| bg: GameScene[page].bg, | ||
| choices: GameScene[page].choices, | ||
| message: GameScene[page].message, | ||
| goto: GameScene[page].goto, | ||
| }} | ||
| setPage={setPage} | ||
| />; |
There was a problem hiding this comment.
Is it unused? If yes this should be removed
src/pages/game/index.tsx
Outdated
| import GameScene from './lib/Scene'; | ||
|
|
||
| const GameLogic = () => { | ||
| const [page, setPage] = useState<string>('Game01'); |
There was a problem hiding this comment.
"Game01" should be changed into Enum or any const vars instead to prevent typos.
| import Image from 'next/image'; | ||
| import scene4 from '@/public/images/gameBG/scene4.svg'; | ||
| import scene7 from '@/public/images/gameBG/scene17.svg'; | ||
| export default function GameBackground(bg: any) { |
There was a problem hiding this comment.
Suggested change
| export default function GameBackground(bg: any) { | |
| export default function GameBackground({ bg }: { bg: string }) { |
Try avoiding any type.
src/pages/game/lib/GameContainer.tsx
Outdated
Comment on lines
67
to
73
| scene: { | ||
| bg: string; | ||
| id: string; | ||
| message: any; | ||
| choices: Question[]; | ||
| goto: string; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| scene: { | |
| bg: string; | |
| id: string; | |
| message: any; | |
| choices: Question[]; | |
| goto: string; | |
| }; | |
| scene: Scene; |
Import type Scene
| import scene4 from '@/public/images/gameBG/scene4.svg'; | ||
| import scene7 from '@/public/images/gameBG/scene17.svg'; | ||
| export default function GameBackground(bg: any) { | ||
| switch (bg.bg) { |
There was a problem hiding this comment.
Suggested change
| switch (bg.bg) { | |
| switch (bg) { |
I am not sure about this but bg is already a type string, isn't?
src/pages/game/lib/Scene.tsx
Outdated
Comment on lines
5
to
8
| export type Scene = Record< | ||
| string, | ||
| { bg: string; message: any; choices: Question[]; goto: string } | ||
| >; |
There was a problem hiding this comment.
Add type scene
Suggested change
| export type Scene = Record< | |
| string, | |
| { bg: string; message: any; choices: Question[]; goto: string } | |
| >; | |
| import React from 'react'; | |
| export type Scene = { | |
| id?: string; | |
| bg: string; | |
| message: React.JSX.Element; | |
| choices: Question[]; | |
| goto: string; | |
| }; | |
| export type Scenes = Record<string, Scene>; |
src/pages/game/lib/Scene.tsx
Outdated
| string, | ||
| { bg: string; message: any; choices: Question[]; goto: string } | ||
| >; | ||
| const GameScene: Scene = { |
There was a problem hiding this comment.
Suggested change
| const GameScene: Scene = { | |
| const GameScene: Scenes = { |
src/pages/game/lib/Scene.tsx
Outdated
| @@ -0,0 +1,127 @@ | |||
| import type { NextPage } from 'next'; | |||
There was a problem hiding this comment.
Move this file to /dto instead as not exporting React Component (e.g. <p>hello</p>) as default will raise errors.
feat: add planets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change made
Describe what you have done
New Features
Fix
Others