Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

feat: scan qr #73

Merged
merged 4 commits into from
Jul 30, 2023
Merged

feat: scan qr #73

merged 4 commits into from
Jul 30, 2023

Conversation

Suprawich
Copy link
Contributor

Change made

  • Bug fixes
  • [ / ] New features
  • Breaking changes

Describe what you have done

New Features

Fix

Others

@Suprawich Suprawich requested review from betich and shalluv July 28, 2023 15:45
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rpkm66-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2023 8:20pm

src/pages/scan.tsx Outdated Show resolved Hide resolved
src/pages/scan.tsx Outdated Show resolved Hide resolved
shalluv
shalluv previously approved these changes Jul 29, 2023
Copy link
Member

@shalluv shalluv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the work for the sake of passing it on to Boom, so this PR will not be blocked by my requested changes. However, please make the requested changes.

@Suprawich
Copy link
Contributor Author

@boomchanotai แก้ให้แล้วครับฝากดูให้ทีครับ

boomchanotai
boomchanotai previously approved these changes Jul 29, 2023
Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job!

</button>
</div>
</div>
<div className="inset-0 flex w-full items-center justify-center bg-black">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inset-0 do nothing

It should be use with postition: absolute or fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ลบ inset-0 ไปแล้วครับ แต่ตรง vercel ข้างล่างต้องแก้ยังไงหรอครับ

Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job ! เมื่อคืนหา type ของ lib ตัวนี้อยู่เหมือนกัน แต่สรุป any ไปเหอะ มันไม่มี type ให้ 5555

@boomchanotai boomchanotai merged commit 8de38c0 into dev Jul 30, 2023
2 checks passed
@leomotors leomotors deleted the feature/rkm66-71-scan-qr branch August 3, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants