This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
refactor: button component #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shalluv
suggested changes
Jul 23, 2023
src/components/DefaultButton.tsx
Outdated
|
|
||
| const DefaultButton = ({ content, additionalStyle, onClick, disabled }) => { | ||
| const buttonClassName = | ||
| `max-w-full w-40 mx-auto items-center py-2 text-white transition-all duration-500 hover:ring-8 disabled:cursor-not-allowed disabled:ring-0 ` + |
There was a problem hiding this comment.
There is no need to explicitly declare a variable, just write to the className attribute of the button.
There was a problem hiding this comment.
You can also use import clsx from 'clsx' to concatenate class.
leomotors
reviewed
Jul 24, 2023
src/components/DefaultButton.tsx
Outdated
|
|
||
| const DefaultButton = ({ content, additionalStyle, onClick, disabled }) => { | ||
| const buttonClassName = | ||
| `max-w-full w-40 mx-auto items-center py-2 text-white transition-all duration-500 hover:ring-8 disabled:cursor-not-allowed disabled:ring-0 ` + |
There was a problem hiding this comment.
You can also use import clsx from 'clsx' to concatenate class.
Comment on lines
151
to
158
| {/* <button | ||
| className="mx-auto rounded-lg bg-pink-400 px-3 py-2 text-xl text-white ring-4 ring-pink-400/30 transition-all duration-500 enabled:hover:ring-8 disabled:cursor-not-allowed disabled:bg-pink-300" | ||
| onClick={() => openModal('modal-leave-group')} | ||
| disabled={!isAuthenticated || group?.leaderID === user?.id} | ||
| > | ||
| ออกจากกลุ่ม | ||
| </button> | ||
| </button> */} | ||
| </div> |
There was a problem hiding this comment.
Uncomment and delete these after finished
boomchanotai
suggested changes
Jul 29, 2023
src/components/Button.tsx
Outdated
| @@ -0,0 +1,15 @@ | |||
| import React from 'react'; | |||
|
|
|||
| const Button = ({ content, additionalStyle, onClick, disabled }) => { | |||
There was a problem hiding this comment.
Please add typescript for this component's props
src/context/AuthContext.tsx
Outdated
| @@ -46,6 +46,7 @@ const AuthProvider = ({ children }: { children: ReactNode }) => { | |||
| const token = localStorage.getItem('token'); | |||
| if (token) { | |||
| const userProfile = await getUserProfile(); | |||
| console.log(userProfile); | |||
There was a problem hiding this comment.
Please delete console.log if it not necessary
shalluv
approved these changes
Jul 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change made
Describe what you have done
New Features
Fix
Others