Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

Feature/rkm66 70 home page e stamp #65

Merged
merged 27 commits into from
Jul 29, 2023

Conversation

D33102
Copy link
Contributor

@D33102 D33102 commented Jul 21, 2023

  • New features : E-ticket home page... (UI & E-stamps)

@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rpkm66-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2023 9:11am

boomchanotai
boomchanotai previously approved these changes Jul 29, 2023
Copy link
Member

@boomchanotai boomchanotai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

btw my comment is just suggestion but If it work let it work

<div className="justify-cente mx-8 flex items-center">
<div className="relative aspect-square h-36 w-24 max-w-full rounded-xl ring-4 ring-blue-950">
<Image
src={user?.imageUrl || placeHolder}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files which store in public folder is already static file. so you can /images/pfp-placeholder.svg in src without import.

<div className="my-3 flex w-4/5 flex-col items-center justify-center text-xl font-bold md:w-1/2">
<div className="relative aspect-square h-auto w-full max-w-full">
<Image
src={eStampBorder}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as I've recomended

@boomchanotai boomchanotai merged commit a62e20d into dev Jul 29, 2023
2 checks passed
@leomotors leomotors deleted the feature/rkm66-70-home-page-e-stamp branch August 3, 2023 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants