Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/pet update and changeview #9

Merged
merged 6 commits into from
Dec 25, 2023
Merged

feature/pet update and changeview #9

merged 6 commits into from
Dec 25, 2023

Conversation

bookpanda
Copy link
Contributor

Pet Service

  • Update: updates pet with new value + return with image urls
  • ChangeView: change visibility of pet
  • add imageService as dependency to PetService

Tests are also added

Nitiwat-owen
Nitiwat-owen requested changes Dec 24, 2023
View reviewed changes
Copy link
Member

@Nitiwat-owen Nitiwat-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the logic is looking good.

src/app/service/pet/pet.service.go Outdated Show resolved Hide resolved
src/app/service/pet/pet.service_test.go Outdated Show resolved Hide resolved
@bookpanda bookpanda merged commit f4d4aff into dev Dec 25, 2023
2 checks passed
@bookpanda bookpanda deleted the feature/pet-update branch December 25, 2023 09:17
@linear linear bot mentioned this pull request Jan 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nitiwat-owen Nitiwat-owen Nitiwat-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bookpanda @Nitiwat-owen