Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unescaped field ident for TryFromValue & TryToValue #18

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

yasamoka
Copy link
Contributor

This allows escaped fields such as r#type to be converted properly.

I also added some test cases to cover missing fields in general as well as escaped fields in both params and responses.

Thank you very much!

@decathorpe
Copy link
Member

Looks good to me at first glance, thank you! I'll let the CI run and take a closer look at the code and new test code later.

@decathorpe
Copy link
Member

Sorry for the late response, I caught covid two weeks ago and am only now getting back into work. The changes look good to me, and thank you for expanding the tests to cover the new feature. I'll publish a new release soon.

@decathorpe decathorpe merged commit 9b4f7c5 into ironthree:main Dec 31, 2023
5 checks passed
@yasamoka
Copy link
Contributor Author

Sorry for the late response, I caught covid two weeks ago and am only now getting back into work. The changes look good to me, and thank you for expanding the tests to cover the new feature. I'll publish a new release soon.

No worries, there was no rush. Hope you're doing better now. I had tried doing work back when I had caught the virus early 2022 and crashed very hard, yet my case was mild, so I totally understand.

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants