added bulk create method for posting 1+ N tasks in single api call #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@sunloverz can you review implementation? |
| def tasks_bulk_create(code_name, params = [], options = {}) | ||
| IronCore::Logger.debug 'IronWorkerNG', "Calling tasks.bulk_create_legacy with code_name='#{code_name}', params='#{params.to_s}' and options='#{options.to_s}'" | ||
|
|
||
| res = @api.tasks_bulk_create(code_name, params.is_a?(Array) ? params : params.to_json, options) |
There was a problem hiding this comment.
Code looks good to me. How about passing just params without checking params.is_a?(Array), if you pass string it will raise en error NoMethodError: undefined method `map!' for String
|
@Stephenitis any updates here? |
|
@Stephenitis ping. wanna get this merged? |
|
Can you guys get this into iron_worker_ruby too (nearly the same code, was copied over). https://github.com/iron-io/iron_worker_ruby NG will probably be deprecated soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api allows for bulk posting of tasks but the ruby but the tasks.create method was not changeable to fit this behavior without possibly breaking code where previous users would have an array as their payload rather than an array of payloads.