[irods/irods#7265,irods/irods#7434,#55,#80,#82] Remove boost.url submodule + CMake TLC #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
Dec 7, 2023
|
If there's nothing else left to do for this, please run the docker test suite. It's fully self contained AFAIK. The instructions are at the bottom of the README. |
SwooshyCueb
force-pushed
the
cmake-tlc.main
branch
from
b021b1d
to
0d0a306
Compare
|
All tests pass |
|
Excellent. Let's get that review comment resolved and add the pounds. |
SwooshyCueb
force-pushed
the
cmake-tlc.main
branch
from
0d0a306
to
a0c13a7
Compare
|
#'d |
korydraughn
approved these changes
Dec 11, 2023
|
@alanking Ready for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses irods/irods#7265
Addresses irods/irods#7434
Addresses #55
Addresses #80
Addresses #82
There's still a couple of CMake consistency changes that need to be made, but they will be addressed as part of #78.