Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add team pictures to the focus area pages #750

Merged
merged 6 commits into from
May 4, 2021

Conversation

davidlange6
Copy link
Member

closes #715

@henryiii
Copy link
Collaborator

Can't we use standard_person_card?

@davidlange6
Copy link
Member Author

that's what I started from (perhaps hard to tell that now). I don't think we would want so much space taken up by pictures on the focus area / team pages, so I made them much smaller.

@henryiii henryiii merged commit b309593 into iris-hep:master May 4, 2021
@henryiii
Copy link
Collaborator

henryiii commented May 4, 2021

I've started refactoring the looping code a bit. We should be able to use find (new in 4.x) and where to clean up our loops (https://jekyllrb.com/docs/liquid/filters/), and it's really easy to add a Ruby filter for the more advanced stuff. That should be much more readable / maintainable, and is much faster (liquid is slow due to all the double looping we tend to do).

@henryiii
Copy link
Collaborator

henryiii commented May 4, 2021

This doesn't work for focus-areas that don't have projects, like ssc and ssl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add team members to focus area pages
2 participants