Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub field for Ridolfi Fellow project #1616

Closed
wants to merge 11 commits into from

Conversation

peterridolfi
Copy link
Contributor

No description provided.

@matthewfeickert matthewfeickert changed the title Add presentation url Add GitHub field for Ridolfi Fellow project Oct 4, 2022
<br>
GitHub url: <a href="https://github.com/peterridolfi/Pyhf-to-Combine-converter.git">https://github.com/peterridolfi/Pyhf-to-Combine-converter.git</a>
focus-area: as
git-hub url: https://github.com/peterridolfi/Pyhf-to-Combine-converter.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
git-hub url: https://github.com/peterridolfi/Pyhf-to-Combine-converter.git

Hm. @henryiii @rct225 from https://iris-hep.org/docs/fellow it doesn't look like there is any schema field for a project URL. Do we not support this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewfeickert We do have github-username, which we present as their GitHub repo on their page. I suppose we can add a field to the project for project-urls. I prefer "project-url" since some people are using gitlab as well as GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay well sounds like it isn't something that is currently supported in the spec so I'll make an Issue from this and close this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be best for now. The "url" under the presentation section is generally for the slides used during their talk, similar to what we do for IRIS-HEP member presentations and talks.

@matthewfeickert
Copy link
Member

Closing as Issue #1620 needs to be implemented for something like this to be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analysis Systems fellowship-project Related to IRIS-HEP Fellow projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants