-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing/http: add more type and WithDynamicProviderInfo #443
Conversation
Codecov Report
@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 50.11% 49.50% -0.61%
==========================================
Files 249 246 -3
Lines 29998 29950 -48
==========================================
- Hits 15033 14827 -206
- Misses 13532 13687 +155
- Partials 1433 1436 +3
|
7ae3e0d
to
a97f44f
Compare
@hacdias this is a pretty simple change that adds a callback instead of statically hardcoding the listen addresses, I would be surprised if this can't be forward ported. |
@Jorropo feel free to rebase and ping me after. |
I'll probably do that for Kubo v0.24 |
2023-10-05 conversation: we aren't going to invest time in this until /routing/v1 PUTs get addressed: ipfs/specs#378. We aren't spending time fixing bugs here. |
This is required to fix a bug in Kubo where we advertise the listening addresses.
We can't pass our real addresses once since thing like autonat takes time.