Buffer shim is no longer working in the Browser as expected

[joaosantos15]

For #649
Adds a failing test for when adding an NPM Buffer:

let Buffer = require('buffer/').Buffer
let expectedBufferMultihash = 'QmWfVY9y3xjsixTgbd9AorQxH7VtMpzfx2HaWtsoUYecaX'
let file = Buffer.from('hello')

ipfs.files.add(file, ...

[joaosantos15]

cc @diasdavid

[daviddias]

Thanks @joaosantos15! Will this PR bring the fix as well?

[daviddias]

Why the /?

[joaosantos15]

It's to depend on that module specifically. I tested without it and it was using Nodejs core Buffer module.
I read about the usage here:.

To require this module explicitly, use require('buffer/') which tells the node.js module lookup algorithm (also used by browserify) to use the npm module named buffer instead of the node.js core module named buffer!

[hacdias]

There is no buffer package being imported. Am I missing some point?

[daviddias]

@hacdias mind checking this one?

[hacdias]

@joaosantos15 @diasdavid I've got one thing to ask: we support the native Node.js Buffer. So, why are trying to support feross/buffer? This way, we should support every single Buffer package which is on NPM.

Why don't we do something similar to what js-ipfs does? Just make Buffer part of the type so when someone uses it in the browser they can use ipfsApi.types.Buffer?

[hacdias]

@diasdavid could you take a look at my previous comment? 😄

[daviddias]

@hacdias the feross/Buffer package is the browser shim that every Bundler (browserify, webpack, etc) uses to shim the Node.js Buffer.

I started getting this issue as well on #688

I believe @vmx had found problems with feross/Buffer package. @vmx will feross/buffer#178 fix this issue?

[vmx]

@diasdavid I don't think feross/buffer#178 will fix the issue. Though I think that once feross/buffer#177 is done, it might fix the issue (178 is just a small part of that. But I won't spend more time on it until I got feedback on it).

[daviddias]

merging into a branch so that we all can edit.

[daviddias]

Follow on #689