buildTrunkPackage: set --release=true on newer trunk versions (#736)

ipetkov · Nov 8, 2024 · f53b0b9 · f53b0b9
1 parent a4ca939
commit f53b0b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+### Fixed
+* `buildTrunkPackage` will pass in `--release=true` (instead of just
+  `--release`) for trunk versions 0.21 or higher to avoid argument ambiguities
+
 ## [0.19.1] - 2024-10-12
 
 ### Added

diff --git a/lib/buildTrunkPackage.nix b/lib/buildTrunkPackage.nix
@@ -84,7 +84,7 @@ mkCargoDerivation (args // {
   buildPhaseCargoCommand = args.buildPhaseCommand or ''
     local profileArgs=""
     if [[ "$CARGO_PROFILE" == "release" ]]; then
-      profileArgs="--release"
+      profileArgs="--release${lib.optionalString (lib.versionAtLeast trunk.version "0.21") "=true"}"
     fi
 
     trunk ${trunkExtraArgs} build $profileArgs ${trunkExtraBuildArgs} "${trunkIndexPath}"