Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIP-42: Account Output Type #144

Draft
wants to merge 142 commits into
base: main
Choose a base branch
from
Draft

TIP-42: Account Output Type #144

wants to merge 142 commits into from

Conversation

PhilippGackstatter
Copy link

Rendered Version

Note that:

  • This TIP is in Draft mode and as such is still being updated.
  • Links to other new TIPs don't work and will only work once the TIP is merged.

PhilippGackstatter and others added 30 commits May 5, 2023 10:30
@PhilippGackstatter
Add TIP-42 skeleton
39711b8
@PhilippGackstatter
Add Block Issuer Feature partially
2dcf8c0
@PhilippGackstatter
Fix table of contents; header indentation
197a277
@PhilippGackstatter
Add Manalock UC & define soulbound Mana
cfe2f9f
@PhilippGackstatter
Use public keys as block issuer keys
cf316d6
@PhilippGackstatter
Update Block Issuer Feature TX valid. rules
234facf
@PhilippGackstatter
Rename Alias -> Account
451eca9
@PhilippGackstatter
Add Block Issuer Feature to acc. validation rules
3dcc05e
@PhilippGackstatter
Remove outdated commented rule
bceccbd
@PhilippGackstatter @cyberphysic4l
Update tips/TIP-0042/tip-0042.md
cef2fe8 
Co-authored-by: Andrew Cullen <[email protected]>
@PhilippGackstatter
Remove Manalock to move it to TIP-38
0a9c0b8
@PhilippGackstatter
Remove manalock unlock condition from ToC
933747f
@PhilippGackstatter
Remove chain constraint unlock description
78c0844
@roman1e2f5p8s
Added mana_amount, storage deposit calc
4fa4f4f
@PhilippGackstatter
Add summary & motivation
a07c506
@PhilippGackstatter
Remove storage deposit figures
ba8b5f7
@PhilippGackstatter
Use Mana Amount as the field name
c065500
@PhilippGackstatter
Make Mana Amount rule consistent
6f7247f
@PhilippGackstatter
Update v_byte min and max
ad16243
@PhilippGackstatter
Replace soulbound mana equation, use timelock
82c7a99
@PhilippGackstatter
Update header
36c5abb
@PhilippGackstatter
Expand MCA & add explicit Issuer Deposit
30a6717
@PhilippGackstatter
Add Block Issuer Feature to storage deposit calc
12d7863
@PhilippGackstatter
Format markdown
9c7befc
@PhilippGackstatter
Add Block Issuer Keys Count
a36926a
@cyberphysic4l
update Mana/BIC wording
7b28bc9
@cyberphysic4l
remove mana amount less than supply check
a7d2f78
@PhilippGackstatter
Update field type of Ed25519 public key
4289478
@PhilippGackstatter
Add Staking Feature to the Account
98beef9
@PhilippGackstatter
Remove fixed cost todo
a703a19
@PhilippGackstatter PhilippGackstatter mentioned this pull request Jan 17, 2024
Closed
@PhilippGackstatter @thibault-martinez
Update tips/TIP-0042/tip-0042.md
2a1e1a0 
Co-authored-by: Thibault Martinez <[email protected]>
thibault-martinez
thibault-martinez reviewed Feb 1, 2024
View reviewed changes
tips/TIP-0042/tip-0042.md Outdated
- A _Commitment Input_ is present.
- A _Block Issuance Credit Input_ is present whose `Account ID` equals that of the account being transitioned.
- When a <i>Block Issuer Feature</i> is present in an account input, the transaction is invalid if that account has
negative Block Issuance Credit, whose value is taken from the _Block Issuance Credit Input_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what "value"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, that is very unclear from this. I updated the TIP, which raises another question for me: Can you even query the BIC balance of an account via an API at a certain commitment?
This resolution process that is described happens in the node before executing the TX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez left review comments

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@Thoralf-M Thoralf-M Thoralf-M left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PhilippGackstatter @thibault-martinez @DaughterOfMars @Thoralf-M @roman1e2f5p8s @cyberphysic4l