This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 370
Feature: Stop solidifying when asked for pruned transaction #1418
Open
kwek20
wants to merge
22
commits into
iotaledger:dev
Choose a base branch
from
kwek20:transaction-pruning-saving
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
force-pushed
the
transaction-pruning-saving
branch
from
April 25, 2019 15:10
0a397ef
to
0dcd59c
Compare
Need to properly prioritize the merging of this PR |
jakubcech
added
C-Spent Addresses
Deffered
Will be addressed and merged in later versions.
labels
May 7, 2019
kwek20
force-pushed
the
transaction-pruning-saving
branch
from
May 14, 2019 15:43
0dcd59c
to
0402ca4
Compare
…vider with additional checks
kwek20
force-pushed
the
transaction-pruning-saving
branch
from
May 14, 2019 16:20
0402ca4
to
3ac580b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we receive a transaction hash which is in the PrunedTransactionProvider we add the hash to the PrunedTransactionVerifier, and stop the rest of the receiving transaction process.
These transactions are used to prove that a transaction hash is pruned before. We deem 10 parents of the original transaction, which are pruned, enough safety to say it was pruned.
Once it is proven, the transaction hash stays in memory marked as pruned until a restart.
When one of the parents of a requested transaction is NOT pruned, the entire chain is proven to be false positives. Chain is discarded and initial transaction is marked as "false positive" to prevent the tx requesting to start over again. Just like the pruned state, this false positive state does not persist upon restarts.
Fixes #1371
To be merged after #1417
Type of change
How Has This Been Tested?
Need a review over the implementation before testing further
Checklist:
Please delete items that are not relevant.