This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
feat: remove tips parameter from getInclusionStates #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRI version 1.8.6 [removes](https://github.com/iotaledger/iri/pull/1685/files) tip parameter from getInclusionStates api call. This commit removes the support for tips parameter. getLatestInclusion() is also removed. getLatestInclusion() basically fetched the states by passing latest solid subtangle milestone. It is no longer necessary as IRI now uses latest subtangle milestone by default. Related: iotaledger/iri#1851
laumair
added
C - core
L - Awaiting reviews
rajivshah3
approved these changes
Jun 14, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
IRI version 1.8.6 removes tip parameter from getInclusionStates api call. This PR removes the support for tips parameter.
getLatestInclusion()is also removed.getLatestInclusion()basically fetched the states by passing latest solid subtangle milestone. It is no longer necessary as IRI now uses latest subtangle milestone by default.Related: iotaledger/iri#1851
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.