Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow actions #1950

Merged
merged 2 commits into from
May 24, 2024

Checkout code before setting up go

2de90e7
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Update workflow actions #1950

Checkout code before setting up go
2de90e7
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci failed May 24, 2024 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (17)

pkg/model/migrator/receipt.go|78 col 12| G306: Expect WriteFile permissions to be 0600 or less (gosec)
pkg/jwt/jwt.go|84 col 53| unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
pkg/database/pebble.go|41 col 44| unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
pkg/database/pebble.go|46 col 42| unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
components/autopeering/component.go|230 col 64| unused-parameter: parameter 'conn' seems to be unused, consider removing or renaming it as _ (revive)
components/autopeering/component.go|249 col 70| unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
components/pow/component.go|36 col 27| unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
pkg/pruning/pruning.go|362 col 9| unused-parameter: parameter 'parentBlockID' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/gossip/service.go|614 col 66| unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
pkg/protocol/gossip/msg_proc.go|129 col 20| unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive)
components/protocfg/component.go|70 col 27| unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
components/restapi/component.go|94 col 9| unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
components/inx/server_blocks.go|147 col 92| unused-parameter: parameter 'latestMilestoneIndex' seems to be unused, consider removing or renaming it as _ (revive)
components/inx/server_blocks.go|208 col 92| unused-parameter: parameter 'index' seems to be unused, consider removing or renaming it as _ (revive)
pkg/tangle/tangle_processor.go|74 col 29| Function RunTangleProcessor$3$1->Broadcast should pass the context parameter (contextcheck)
pkg/tangle/tangle_processor.go|107 col 58| Function RunTangleProcessor$5$1->RunTangleProcessor$5$1$1->processValidMilestone->processValidMilestone$1->solidifyMilestone->ConfirmMilestone->ConfirmMilestone$2 should pass the context parameter (contextcheck)
pkg/toolset/database_verify.go|241 col 38| Function verifyDatabase$3->ConfirmMilestone->ConfirmMilestone$2 should pass the context parameter (contextcheck)

Filtered Findings (0)

Annotations

Check failure on line 78 in pkg/model/migrator/receipt.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/model/migrator/receipt.go#L78

G306: Expect WriteFile permissions to be 0600 or less (gosec)
Raw output
pkg/model/migrator/receipt.go:78:12: G306: Expect WriteFile permissions to be 0600 or less (gosec)
	if err := os.WriteFile(receiptFileName, receiptJSON, os.ModePerm); err != nil {
	          ^

Check failure on line 84 in pkg/jwt/jwt.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/jwt/jwt.go#L84

unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/jwt/jwt.go:84:53: unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
			handler := middleware.JWTWithConfig(config)(func(c echo.Context) error {
			                                                 ^

Check failure on line 41 in pkg/database/pebble.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/database/pebble.go#L41

unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/database/pebble.go:41:44: unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
	opts.EventListener.CompactionBegin = func(info pebbleDB.CompactionInfo) {
	                                          ^

Check failure on line 46 in pkg/database/pebble.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/database/pebble.go#L46

unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/database/pebble.go:46:42: unused-parameter: parameter 'info' seems to be unused, consider removing or renaming it as _ (revive)
	opts.EventListener.CompactionEnd = func(info pebbleDB.CompactionInfo) {
	                                        ^

Check failure on line 230 in components/autopeering/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/autopeering/component.go#L230

unused-parameter: parameter 'conn' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/autopeering/component.go:230:64: unused-parameter: parameter 'conn' seems to be unused, consider removing or renaming it as _ (revive)
			deps.PeeringManager.Events.Connected.Hook(func(p *p2p.Peer, conn network.Conn) {
			                                                            ^

Check failure on line 249 in components/autopeering/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/autopeering/component.go#L249

unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/autopeering/component.go:249:70: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
			deps.PeeringManager.Events.Disconnected.Hook(func(peer *p2p.Peer, err error) {
			                                                                  ^

Check failure on line 36 in components/pow/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/pow/component.go#L36

unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/pow/component.go:36:27: unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
	if err := c.Provide(func(deps handlerDeps) *pow.Handler {
	                         ^

Check failure on line 362 in pkg/pruning/pruning.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/pruning/pruning.go#L362

unused-parameter: parameter 'parentBlockID' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/pruning/pruning.go:362:9: unused-parameter: parameter 'parentBlockID' seems to be unused, consider removing or renaming it as _ (revive)
			func(parentBlockID iotago.BlockID) error { return nil },
			     ^

Check failure on line 614 in pkg/protocol/gossip/service.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/protocol/gossip/service.go#L614

unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/gossip/service.go:614:66: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
		s.peeringManager.Events.Disconnected.Hook(func(peer *p2p.Peer, err error) {
		                                                               ^

Check failure on line 129 in pkg/protocol/gossip/msg_proc.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/protocol/gossip/msg_proc.go#L129

unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
pkg/protocol/gossip/msg_proc.go:129:20: unused-parameter: parameter 'data' seems to be unused, consider removing or renaming it as _ (revive)
		func(key []byte, data []byte) (objectstorage.StorableObject, error) {
		                 ^

Check failure on line 70 in components/protocfg/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/protocfg/component.go#L70

unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/protocfg/component.go:70:27: unused-parameter: parameter 'deps' seems to be unused, consider removing or renaming it as _ (revive)
	if err := c.Provide(func(deps cfgDeps) cfgResult {
	                         ^

Check failure on line 94 in components/restapi/component.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/restapi/component.go#L94

unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/restapi/component.go:94:9: unused-parameter: parameter 'err' seems to be unused, consider removing or renaming it as _ (revive)
			func(err error, c echo.Context) {
			     ^

Check failure on line 147 in components/inx/server_blocks.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/inx/server_blocks.go#L147

unused-parameter: parameter 'latestMilestoneIndex' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/inx/server_blocks.go:147:92: unused-parameter: parameter 'latestMilestoneIndex' seems to be unused, consider removing or renaming it as _ (revive)
	unhook := deps.Tangle.Events.ReceivedNewBlock.Hook(func(cachedBlock *storage.CachedBlock, latestMilestoneIndex iotago.MilestoneIndex, confirmedMilestoneIndex iotago.MilestoneIndex) {
	                                                                                          ^

Check failure on line 208 in components/inx/server_blocks.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] components/inx/server_blocks.go#L208

unused-parameter: parameter 'index' seems to be unused, consider removing or renaming it as _ (revive)
Raw output
components/inx/server_blocks.go:208:92: unused-parameter: parameter 'index' seems to be unused, consider removing or renaming it as _ (revive)
	unhook := deps.Tangle.Events.BlockReferenced.Hook(func(blockMeta *storage.CachedMetadata, index iotago.MilestoneIndex, confTime uint32) {
	                                                                                          ^

Check failure on line 74 in pkg/tangle/tangle_processor.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/tangle/tangle_processor.go#L74

Function `RunTangleProcessor$3$1->Broadcast` should pass the context parameter (contextcheck)
Raw output
pkg/tangle/tangle_processor.go:74:29: Function `RunTangleProcessor$3$1->Broadcast` should pass the context parameter (contextcheck)
			t.Events.BlockSolid.Hook(func(cachedBlockMeta *storage.CachedMetadata) {
			                         ^

Check failure on line 107 in pkg/tangle/tangle_processor.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/tangle/tangle_processor.go#L107

Function `RunTangleProcessor$5$1->RunTangleProcessor$5$1$1->processValidMilestone->processValidMilestone$1->solidifyMilestone->ConfirmMilestone->ConfirmMilestone$2` should pass the context parameter (contextcheck)
Raw output
pkg/tangle/tangle_processor.go:107:58: Function `RunTangleProcessor$5$1->RunTangleProcessor$5$1$1->processValidMilestone->processValidMilestone$1->solidifyMilestone->ConfirmMilestone->ConfirmMilestone$2` should pass the context parameter (contextcheck)
			t.milestoneManager.Events.ReceivedValidMilestone.Hook(func(cachedMilestone *storage.CachedMilestone, requested bool) {
			                                                      ^

Check failure on line 241 in pkg/toolset/database_verify.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] pkg/toolset/database_verify.go#L241

Function `verifyDatabase$3->ConfirmMilestone->ConfirmMilestone$2` should pass the context parameter (contextcheck)
Raw output
pkg/toolset/database_verify.go:241:38: Function `verifyDatabase$3->ConfirmMilestone->ConfirmMilestone$2` should pass the context parameter (contextcheck)
	applyAndCompareLedgerStateChange := func(
	                                    ^