Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace httpretty #1125

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Replace httpretty #1125

merged 1 commit into from
Nov 21, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 21, 2024

httpretty seems to be abandoned and some of its deprecation warnings will make it unsuable soon. See gabrielfalcao/HTTPretty#482

I'm replace it with mocket, which seems to have a 1-1 correspondence and seems to be well maintained.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (37ef414) to head (5c56994).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1125   +/-   ##
========================================
  Coverage    82.17%   82.17%           
========================================
  Files           25       25           
  Lines         5206     5206           
  Branches      1162     1162           
========================================
  Hits          4278     4278           
  Misses         627      627           
  Partials       301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 21, 2024

The docs failure is unrelated to this PR:

(             faq: line   24) broken    https://standards.sensors.ioos.us/erddap/tabledap/morro-bay-bs1-met.html - 502 Server Error: Bad Gateway for url

If that link is not back online we will need to remove/find an alternative to it

@ocefpaf ocefpaf merged commit 7d62f4f into ioos:develop Nov 21, 2024
26 of 27 checks passed
@ocefpaf ocefpaf deleted the replace_httpretty branch November 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant