Feat/rmet 3901/watch position #2
Draft
+32,437
−4,248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS-ricardomoreirasilva
force-pushed
the
feat/rmet-3901/watch-position
branch
2 times, most recently
from
5327c2f to
7bdfb6b
Compare
Using Combine, the main idea is to use publishers to track the location and authorisation status updates.
OS-ricardomoreirasilva
force-pushed
the
feat/rmet-3901/watch-position
branch
from
7bdfb6b to
dc6a0a6
Compare
Update the generated definitions to the latest version. Considering that the plugin.xml needs to be on the root folder, there's no need to have it inside the cordova-plugin folder.
OS-ricardomoreirasilva
force-pushed
the
feat/rmet-3901/watch-position
branch
from
dc6a0a6 to
d45b4b2
Compare
…position # Conflicts: # plugin.xml
This is done differently for Cordova and Capacitor
Use the latest 'alwaysusagedescription' plist entry.
OS-ricardomoreirasilva
force-pushed
the
feat/rmet-3901/watch-position
branch
from
e529143 to
cb6c202
Compare
This is the structure to be used by watchPosition. It's a mix of both CurrentPositionOptions (new name for PositionOptions) and ClearWatchOptions. Add default constant for the new structure. Update Outsystems wrapper implementation.
Setup bindings creates the location publisher with nil value, so this must be dropped in order for the first value to be an actual position.
…ion retrieval Have a similar logic to Cordova
Considering that the `currentLocation` property is initialised at nil, change its publisher to drop the first value automatically (to avoid triggering the initial value) and convert the optional property into a non-optional but failable publisher. Split OSGLOCAuthorisation's granted to authorisedAlways and authorisedWhenInUse. This allows to differ behaviour between both. Adapt tests accordingly. Add unit tests to test authorisation and current location sequential changes.
…d new OSGLOCAuthorisation values Remove the no longer needed error case.
…new OSGLOCAuthorisation values Remove the no longer needed error case.
OS-ricardomoreirasilva
force-pushed
the
feat/rmet-3901/watch-position
branch
from
b16043b to
58a5ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.