-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(select): ensure select sizes are respected when the label is empty #30087
Conversation
…height sizes established.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Make sure to have the checks passing before requesting a review. Please review how we write the PR descriptions. This one is missing information on the current behavior. It helps the reviewer understand the issue if there's text vs having to figure out the issue through a repro. It would have taken me some time to understand the issue if I hadn't already known about it prior. But it might have taken some time for someone else since there was no mention of sizes being affected by the lack of a label. Please review how we write the PR titles. We don't end the titles with a period and there's no need to repeat the component name within the title since it's already mentioned in the scope. I would recommend something like: |
- organize select styles so they don't affect ionic theme;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- update all select snapshots; - add empty label select to test page;
Issue number: internal
What is the current behavior?
Currently, the experience planned for ionic select has the sizes fixed and should be respected even when the labels are not presented.
https://stackblitz.com/edit/ku3fqz?file=src%2Fmain.tsx
What is the new behavior?
Does this introduce a breaking change?