Skip to content

Commit

Permalink
- add test for empty label select;
Browse files Browse the repository at this point in the history
- update all select snapshots;
- add empty label select to test page;
  • Loading branch information
JoaoFerreira-FrontEnd committed Dec 19, 2024
1 parent 7a3f3b5 commit 41d04f4
Show file tree
Hide file tree
Showing 44 changed files with 21 additions and 2 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions core/src/components/select/test/size/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -47,20 +47,29 @@ <h2>Small</h2>
<ion-select size="small" fill="outline" label="Label" label-placement="stacked" value="filledText">
<ion-select-option value="filledText">Filled text</ion-select-option>
</ion-select>
<ion-select size="small" fill="outline" label="" label-placement="stacked" value="filledText2">
<ion-select-option value="filledText2">Filled text</ion-select-option>
</ion-select>
</div>

<div class="grid-item">
<h2>Medium</h2>
<ion-select size="medium" fill="outline" label="Label" label-placement="stacked" value="filledText">
<ion-select-option value="filledText">Filled text</ion-select-option>
</ion-select>
<ion-select size="medium" fill="outline" label="" label-placement="stacked" value="filledText2">
<ion-select-option value="filledText2">Filled text</ion-select-option>
</ion-select>
</div>

<div class="grid-item">
<h2>Large</h2>
<ion-select size="large" fill="outline" label="Label" label-placement="stacked" value="filledText">
<ion-select-option value="filledText">Filled text</ion-select-option>
</ion-select>
<ion-select size="large" fill="outline" label="" label-placement="stacked" value="filledText2">
<ion-select-option value="filledText2">Filled text</ion-select-option>
</ion-select>
</div>
</div>
</ion-content>
Expand Down
14 changes: 12 additions & 2 deletions core/src/components/select/test/size/select.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,21 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ config, screens
>
<ion-select-option value="filledText">Filled text</ion-select-option>
</ion-select>
`,
config
);

const select = page.locator('ion-select');

await expect(select).toHaveScreenshot(screenshot(`select-size-${size}`));
});

test(`${size} - should not have visual regressions when label is unset`, async ({ page }) => {
await page.setContent(
`
<ion-select
size="${size}"
fill="outline"
label=""
label-placement="stacked"
value="filledText"
>
Expand All @@ -36,7 +46,7 @@ configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ config, screens

const select = page.locator('ion-select');

await expect(select).toHaveScreenshot(screenshot(`select-size-${size}`));
await expect(select).toHaveScreenshot(screenshot(`select-size-${size}-unset-label`));
});
});
});
Expand Down

0 comments on commit 41d04f4

Please sign in to comment.