refactor(all): update to standalone components #1817
+1,929
−1,569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @brandyscarney 👋 |
brandyscarney
changed the title
|
Hi @Carniatto! Thank you so much for working on this! I’ve created an internal task to review it soon. In the meantime, if you have a moment, could you please take a look at the failing build? You can reproduce the issue locally by running: If you’re unable to check it, no problem, I can take a look when I get a chance. Thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR contains the following migrations:
*ifand*forto@ifand@foranywhere possibleNgOptimizedImageusageThere might have been other small fixes, I've run all E2E and they pass, I've also tested all screens, modals, popovers, etc to the best of my capacity