-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clippy linting #104
base: master
Are you sure you want to change the base?
Add clippy linting #104
Conversation
does clippy lint succeed on the current code? 😄 |
Thanks for the great project, by the way! I just followed it and enjoyed it a lot! There are just a few warnings:
I can make an MR for the !is_empty, but not sure about the complex type ones? |
hey, super glad to hear, thanks for all the fixes, really appreciate it! 🙏 is it possible to ignore the type complexity rule when we run clippy? maybe there is some clippy config where we can add an ignore for this specific rule without changing the code. the rest should be fine to fix, the main thing is to make sure all the code changes stays on the same line, this is very unfortunate but cause we are using line numbers in the book if the code changes significantly it's a pain to change. |
I think there is some clippy config that we can put in Cargo.toml or
somewhere that might avoid adding ignore lines to all the specific files.
I'll see if I can get that working.
…On Sun, 13 Feb 2022 at 17:47, Olivia Ifrim ***@***.***> wrote:
hey, super glad to hear, thanks for all the fixes, really appreciate it!
🙏
is it possible to ignore the type complexity rule when we run clippy?
maybe there is some clippy config where we can add an ignore for this
specific rule without changing the code.
the rest should be fine to fix, the main thing is to make sure all the
code changes stays on the same line, this is very unfortunate but cause we
are using line numbers in the book if the code changes significantly it's a
pain to change.
—
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHBGLRRLQX3JZAWE6UTFAO3U27OCVANCNFSM5OI7437Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Relates to iolivia#13
7108401
to
a9d9365
Compare
Relates to #13