perf(net-core): Enhance the invokeModuleMessage and invokeModuleColle…

…ctMessage methods of the BrokerClientItem. The return value must not be null, and error information is added.
iohao · Dec 11, 2024 · 3ef7eb3 · 3ef7eb3
1 parent 7e80f1e
commit 3ef7eb3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 9 deletions.
diff --git a/common/common-core/src/main/java/com/iohao/game/action/skeleton/protocol/BarMessage.java b/common/common-core/src/main/java/com/iohao/game/action/skeleton/protocol/BarMessage.java
@@ -113,4 +113,8 @@ public BarMessage setError(MsgExceptionInfo msgExceptionInfo) {
     public boolean hasError() {
         return this.responseStatus != 0;
     }
+
+    public boolean success() {
+        return !this.hasError();
+    }
 }
diff --git a/...bolt/bolt-core/src/main/java/com/iohao/game/bolt/broker/core/client/BrokerClientItem.java b/...bolt/bolt-core/src/main/java/com/iohao/game/bolt/broker/core/client/BrokerClientItem.java
@@ -28,6 +28,7 @@
 import com.iohao.game.action.skeleton.core.BarSkeleton;
 import com.iohao.game.action.skeleton.core.SkeletonAttr;
 import com.iohao.game.action.skeleton.core.commumication.CommunicationAggregationContext;
+import com.iohao.game.action.skeleton.core.exception.ActionErrorEnum;
 import com.iohao.game.action.skeleton.protocol.RequestMessage;
 import com.iohao.game.action.skeleton.protocol.ResponseMessage;
 import com.iohao.game.action.skeleton.protocol.collect.RequestCollectMessage;
@@ -53,8 +54,8 @@
 
 import java.io.Serializable;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.Objects;
-import java.util.concurrent.Executor;
 import java.util.concurrent.TimeUnit;
 
 /**
@@ -161,18 +162,17 @@ public void broadcastOrder(ResponseMessage responseMessage) {
 
     @Override
     public ResponseMessage invokeModuleMessage(RequestMessage requestMessage) {
-
-        ResponseMessage o = null;
-
         try {
             InnerModuleMessage moduleMessage = new InnerModuleMessage();
             moduleMessage.setRequestMessage(requestMessage);
-            o = (ResponseMessage) this.invokeSync(moduleMessage);
+            return (ResponseMessage) this.invokeSync(moduleMessage);
         } catch (RemotingException | InterruptedException e) {
             log.error(e.getMessage(), e);
+            var responseMessage = requestMessage.createResponseMessage();
+            responseMessage.setResponseStatus(ActionErrorEnum.systemOtherErrCode.getCode());
+            responseMessage.setValidatorMsg(e.getMessage());
+            return responseMessage;
         }
-
-        return o;
     }
 
     @Override
@@ -196,9 +196,13 @@ public ResponseCollectMessage invokeModuleCollectMessage(RequestMessage requestM
             return (ResponseCollectMessage) this.invokeSync(requestCollectMessage);
         } catch (RemotingException | InterruptedException e) {
             log.error(e.getMessage(), e);
-        }
+            ResponseCollectMessage responseCollectMessage = new ResponseCollectMessage();
+            responseCollectMessage.setStatusCode(ActionErrorEnum.systemOtherErrCode.getCode());
+            responseCollectMessage.setStatusMes(e.getMessage());
+            responseCollectMessage.setMessageList(Collections.emptyList());
 
-        return null;
+            return responseCollectMessage;
+        }
     }
 
     @Override