Added Mask 3D edit #822
Open
Added Mask 3D edit #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The absence of the channel was causing pytorch not to be found on a windows installation (windows 10 22H2, miniconda3, conda 24.4.0)
task_slice.py: - Checkbox for enabling the 3D mask edit - Button for performing the edit - Combobox for choosing the edit mode constants.py: - Style ID for mask edit - Operation constants and mode strings (not localized yet)
tfmoraes
reviewed
Aug 7, 2024
invesalius_cy/mask_cut.pyx
Outdated
Comment on lines
8
to
16
| DTYPEF64 = np.float64 | ||
| ctypedef np.float64_t DTYPEF64_t | ||
|
|
||
| ctypedef fused image_t: | ||
| np.float64_t | ||
| np.int16_t | ||
| np.uint8_t | ||
|
|
||
| ctypedef np.uint8_t mask_t |
There was a problem hiding this comment.
You can import the types from cy_my_types https://github.com/invesalius/invesalius3/blob/master/invesalius_cy/cy_my_types.pxd. Like here https://github.com/invesalius/invesalius3/blob/master/invesalius_cy/floodfill.pyx#L21
There was a problem hiding this comment.
Thank you, I have solved that. Please check the new code
UI modifications to allow drawing a polygon in the volume renderer - Canvas Handler for simple polygon selection and rendering; - Interaction style to create this polygon and communicate to mask edit.
henriquenunez
force-pushed
the
mask_3d_edit
branch
from
d7d94e9 to
bf646f0
Compare
Functionality for using the polygon drawn in the volume viewer to cut the mask has been implemented.
henriquenunez
force-pushed
the
mask_3d_edit
branch
from
bf646f0 to
7aeb2f3
Compare
I also removed that PR. I had run ruff on all files, but that is probably unneeded. |
The user can now select multiple polygons in the volume renderer to perform the edit.
Added controls in task_slice for toggling the "3D mask cut with depth" functionality. Added the button for cleaning up the polygons in the volume viewer.
Implemented with a spin control from 0 to 1. Function parameter improvements in mask_3d_edit.py
henriquenunez
force-pushed
the
mask_3d_edit
branch
from
0ba3912 to
c479d4a
Compare
Fixed the problem by inverting the Y axis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3D edit of masks in InVesalius
These improvements are the result of the Google Summer of Code 2024 project for the InVesalius organization.
The proposal of this project was to include a tool for editing masks in 3D for InVesalius, which can speed up the process of reviewing and adjusting scans. For more information, please visit my blog post.
In a nutshell, the changes I have made in the project were:
Said so, when the "Edit in 3D" checkbox is toggled, the user can draw several polygons on the volume viewer, and when "Cut" is clicked, the operation will be performed. Note that several polygons can be added, as well as arbitrary complex polygons can be used.
Visual demo:
Different modes for mask cut:
Remaining Work
Future improvements