Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to loading markers files #821

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Rakhesis
Copy link
Collaborator

@Rakhesis Rakhesis commented Aug 5, 2024

UI additions:

  • New option to clear all previous markers when loading markers from a file.
  • New button to Image registration page for loading image fiducials from a markers file.

Codebase changes:

  • Dialog to load markers from a file detached from MarkersPanel code.
  • Fast method to add multiple markers added to MarkersControl.

@Rakhesis Rakhesis requested a review from rmatsuda August 5, 2024 18:36
invesalius/gui/dialogs.py Outdated Show resolved Hide resolved
Fast method to add multiple markers.
Does the same optimizations as MarkersPanel.GetMarkersFromFile()
Added option to clear all previous markers.

Decoupled markers loading dialog from MarkersPanel. Code moved to gui/dialogs.py, utils.py, gui/utils.py.

Added functionality for loading image fiducials from markers file.
Checkboxes aligned to the left and put inside a StaticBoxSizer.
@Rakhesis Rakhesis force-pushed the load-markers-improvements branch from 5503a9a to 889f354 Compare September 2, 2024 13:03
ruff pre-commit formatting
@Rakhesis Rakhesis requested a review from rmatsuda September 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants