Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug introduced by moving to pathlib #3419

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Jul 27, 2022

Ref: #3392

A simple typo broke rendering on the "settings" page. This PR fixes that, and also introduces some unit testing to ensure that the settings page gets rendered correctly.

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed old user interface Issues with Old User interface labels Jul 27, 2022
@SchrodingersGat SchrodingersGat added this to the 0.8.0 milestone Jul 27, 2022
@SchrodingersGat SchrodingersGat requested a review from matmair July 27, 2022 03:50
InvenTree/InvenTree/test_views.py Show resolved Hide resolved
InvenTree/InvenTree/test_views.py Show resolved Hide resolved
InvenTree/InvenTree/views.py Show resolved Hide resolved
@SchrodingersGat SchrodingersGat merged commit 851683a into inventree:master Jul 27, 2022
@SchrodingersGat SchrodingersGat deleted the pathlib-fix branch July 27, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed old user interface Issues with Old User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants