record validator addition #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinm
force-pushed
the
validator-endpoint
branch
from
576eb1a
to
7807d7b
Compare
jmartinm
commented
Feb 2, 2017
| """A check that returns a warning.""" | ||
| errors = {} | ||
| if data.get('hello', '') == 'world': | ||
| errors['hello'] = [{ |
There was a problem hiding this comment.
I am assuming that checker functions will return in the key that has the problem a list of errors (even if there is only one). So after I use extend - https://github.com/inveniosoftware-contrib/invenio-record-editor/pull/12/files#diff-71a4f12cd34d737a14762152409ffef7R66
I am not sure if we should allow to return also just a dict for cases with only one problem and deal with it on RecordValidator.validate
jmartinm
force-pushed
the
validator-endpoint
branch
from
7807d7b
to
abd2d50
Compare
2 similar comments
* Adds API endpoint for custom validation of records. * Adds util class RecordValidator for running multiple validation functions. * New config RECORD_EDITOR_VALIDATOR_FUNCTIONS to pass all validation functions that need to run on the record. Signed-off-by: Javier Martin Montull <[email protected]>
jmartinm
force-pushed
the
validator-endpoint
branch
from
abd2d50
to
4db1d93
Compare
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API endpoint for custom validation of records.
Adds util class RecordValidator for running multiple validation functions.
New config RECORD_EDITOR_VALIDATOR_FUNCTIONS to pass all validation
functions that need to run on the record.
Signed-off-by: Javier Martin Montull [email protected]