Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UX change in Author Page #9934

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

h3ri0s
Copy link

@h3ri0s h3ri0s commented Oct 3, 2024

Closes #9928

Design Changes on the UX Author Page. Changed the position of sort dropper

Technical

The sort drop has been moved down for better visibility.

Testing

Please visit the following page ex: /authors/OL18319A/Mark_Twain

Screenshot

image

Stakeholders

Comment on lines +132 to +133
<div style="display: flex; align-items: center;">
<div style="margin-right: 15px; margin-top:10px ">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid inline styles :)

@mekarpeles
Copy link
Member

Looks much better, now we just have to clean up our code a bit so we're not using inline styles.

@mekarpeles mekarpeles added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Oct 4, 2024
@h3ri0s
Copy link
Author

h3ri0s commented Oct 6, 2024

I will make the changes and update . Thanks : )

@h3ri0s
Copy link
Author

h3ri0s commented Oct 11, 2024

Looks much better, now we just have to clean up our code a bit so we're not using inline styles.

Hi, is legacy.less the file where I need to put the CSS?

@mekarpeles
Copy link
Member

https://github.com/internetarchive/openlibrary/blob/377be259788c040a32123ba084d70e20ce612a83/static/css/components/sort-dropper.less is probably a better place than legacy.css as sort-dropper at least deals with the sort dropper

@mekarpeles
Copy link
Member

mekarpeles commented Oct 29, 2024

We also likely want to keep a similar consistent style to book search where it tells us how many results are being returned
Books page
Screenshot 2024-10-28 at 6 13 11 PM

Proposed Author's Page
Screenshot 2024-10-28 at 6 16 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author Search Sort UX
2 participants