-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UX change in Author Page #9934
base: master
Are you sure you want to change the base?
feat: UX change in Author Page #9934
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
<div style="display: flex; align-items: center;"> | ||
<div style="margin-right: 15px; margin-top:10px "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid inline styles :)
Looks much better, now we just have to clean up our code a bit so we're not using inline styles. |
I will make the changes and update . Thanks : ) |
Hi, is |
https://github.com/internetarchive/openlibrary/blob/377be259788c040a32123ba084d70e20ce612a83/static/css/components/sort-dropper.less is probably a better place than legacy.css as sort-dropper at least deals with the sort dropper |
Closes #9928
Design Changes on the UX Author Page. Changed the position of sort dropper
Technical
The sort drop has been moved down for better visibility.
Testing
Please visit the following page ex:
/authors/OL18319A/Mark_Twain
Screenshot
Stakeholders