Store selected TTS voice in localStorage

[sbwhitt]

Closes #1131

TTS voice selection is stored after user selects from voice menu. On load, the last selected voice will attempt to be selected from localStorage and loaded as the active voice. If no voice is stored, the default will be selected.

Voice is stored under the localStorage key 'playback-voice'.

[codecov]

Codecov Report

Merging #1241 (5e5fdb8) into master (650c9f7) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 5e5fdb8 differs from pull request most recent head d4e6c89. Consider uploading reports for the commit d4e6c89 to get more accurate results

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
+ Coverage   69.22%   69.33%   +0.11%     
==========================================
  Files          60       60              
  Lines        5095     5101       +6     
  Branches     1067     1070       +3     
==========================================
+ Hits         3527     3537      +10     
+ Misses       1541     1537       -4     
  Partials       27       27              

Files Changed	Coverage Δ
src/plugins/tts/AbstractTTSEngine.js	55.00% <100.00%> (+7.12%)	⬆️

[cdrini]

Hi, nice thank you @sbwhitt ! This is a great first issue 😊 This would better live inside AbstractTTSEngine.setVoice for the setting, and AbstractTTSEngine.getBestBookVoice for the reading. In getBestBookVoice, you should at the very start of the function check if the book language has preferred voice set in local storage, and output that before all the other logic. Note browsers sometimes change the languages available, so check to make sure the voice is actually available in the voices array!

Overall:

• Move localStorage.getItem to AbstractTTSEngine.getBestBookVoice
• Move localStorage.setItem to AbstractTTSEngine.setVoice
• Make localStorage entry book-language specific (eg BRplayback-voice-en: Foo Bar)
• Handle voice in localStorage missing from voices array
• Add some unit tests for this one in tests/jest/plugins/tts/AbstractTTSEngine.test.js

[sbwhitt]

Hi, nice thank you @sbwhitt ! This is a great first issue 😊 This would better live inside AbstractTTSEngine.setVoice for the setting, and AbstractTTSEngine.getBestBookVoice for the reading. In getBestBookVoice, you should at the very start of the function check if the book language has preferred voice set in local storage, and output that before all the other logic. Note browsers sometimes change the languages available, so check to make sure the voice is actually available in the voices array!

Overall:

• Move localStorage.getItem to AbstractTTSEngine.getBestBookVoice
• Move localStorage.setItem to AbstractTTSEngine.setVoice
• Make localStorage entry book-language specific (eg BRplayback-voice-en: Foo Bar)
• Handle voice in localStorage missing from voices array
• Add some unit tests for this one in tests/jest/plugins/tts/AbstractTTSEngine.test.js

Ok, great, I will be working on this. Thank you for the tips!

[cdrini]

Code looks great @sbwhitt ! Testing it out now...

[cdrini]

Works perfectly! Tested books in different languages, tested that the voice is remembered across languages :) Thank you @sbwhitt !