Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Some demos not working. #1239

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix:Some demos not working. #1239

merged 1 commit into from
Nov 16, 2023

Conversation

xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Sep 14, 2023

issue -:#1103

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1239 (914a373) into master (7361245) will not change coverage.
The diff coverage is n/a.

❗ Current head 914a373 differs from pull request most recent head dfb6bbc. Consider uploading reports for the commit dfb6bbc to get more accurate results

@@           Coverage Diff           @@
##           master    #1239   +/-   ##
=======================================
  Coverage   69.23%   69.23%           
=======================================
  Files          60       60           
  Lines        5097     5097           
  Branches     1066     1066           
=======================================
  Hits         3529     3529           
  Misses       1541     1541           
  Partials       27       27

cdrini
cdrini approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xonx4l ! Confirmed the simple demo now displays correctly.

@cdrini cdrini merged commit 2c562d7 into internetarchive:master Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xonx4l @cdrini