-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsi v2 #331
base: main
Are you sure you want to change the base?
bsi v2 #331
Conversation
@fvsamson @surendrapathak I have read & re-read the BSI v2.0 spec multiple times and i have come up with the compliance doc, before i start the implementations. Wanted to call out a couple of things
|
Yeah, the compliance doc looks good. https://github.com/interlynk-io/sbomqs/blob/feature/bsi-v2/Compliance.md . |
Wow, you are quick. I am currently travelling, so my time is a bit limited and hence at BSI our weekly TR-03183-2 writers team teleconference was cancelled. What I can provide the next days are some replies to @riteshnoronha's points above, hopefully a first proper review of your compliance document sometime this week (just glanced over it now), and I will discuss both (questions and document) with my colleagues at our teleconference next week. Side note: We plan to publish our thinking of mapping TR-03183-2's requirements to CDX and SPDX tags in v2.1.0 of TR-03183-2 (please do not ask when: whenever we and reviewers deem it to be ready, but surely not this year). We are aware, that for a few requirements there are no appropriate tags, but there are a couple of generic ones one can use as This mapping task is primarily performed by a colleague who also has become the one most savvy of us in the CDX and SPDX specifications proper. I will ask him to chime in here next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a slight difference in the meaning between associated license
and concluded license
. But in a multi-licensing example as listed in Annex 8.1.9, I'd consider the choice for the associated license also to be the concluded license.
Who makes the decision seems to be the difference: the SBOM creator (associated) or the component licensee (concluded), which will be the SBOM creator for any direct dependencies.
Example:
- Direct dependency to a component A that declares MIT OR GPL-2.0-only => SBOM creator can decide to use MIT and list that as concluded
- Transitive dependency to the same component A via a directy dependency component B declaring only MIT => creator of component B already made the decision to use MIT, so the SBOM creator has to list MIT as associated license instead of concluded.
Am I right on this one or does it even make a difference in practice?
| | `filename` | component->type(file), name | PackageFileName | TBD | For CycloneDX properties could be used | | ||
| | `dependencies` | dependencies, compositions | relationships | TBD | cdx we look for attestations via compositions, spdx nothing exists | | ||
| | `associated license` | component->license->Expression | packageConcluded | TBD | we lookup sdpx,spdx-exceptions,aboutcode, and licenseRef- | | ||
| | `hash` | component->hashes | package->checksums | TBD | we only look for sha-256 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the guideline specified SHA-512 for "hash value of the deployable component"
Notes:
Rest looks good to me. |
@fvsamson i am going to start development based on my initial take, we can refine it once you have bandwidth to review it. |
Add compliance doc for bsi - v2.0 for review.