feat: limit xcm transfers #727
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
commented
Oct 18, 2022
| } | ||
| } else { | ||
| match first_instruction { | ||
| ReceiveTeleportedAsset(assets) | WithdrawAsset(assets) | ClaimAsset { assets, .. } => { |
There was a problem hiding this comment.
should be ReserveAssetDeposited rather than receiveTeleportedAsset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will still needs tests, cleanup, setter extrinsics, etc, but I'm opening this for feedback on the approach.
Currently the approach is to have configurable limits per currency per 24 hours. The "budget" resets every 24 hours (i.e. it is not a sliding window).
This new pallet implements
TransactAsset, which is basically a proxy for the existing transactor that records the total amounts sent. We then use the barrier implemented in this pallet to deny messages that cross the limit.If we hit the limit, new requests of that currency are denied, but then allowed again after the next 24 hour checkpoint.
Thoughts?