Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill [email protected]
Some initial draft code for supporting taproot spending. As noted in #606, it is not possible to determine the "address" from a key path spending transaction alone since Schnorr signatures do not support public key recovery. Therefore to verify that a P2TR spend is valid we must provide the spentTransactionOutput
when reporting a theft here. Since #603 is merged, we do not explicitly require that inputs to issue, redeem, refund and replace transactions are valid since they only need to verify the output. The benefit of this approach is also to disambiguate witness parsing, we currently assume all non-standard inputs are P2WSH - see this comment.EDIT: since theft reporting was removed the problem described above is no longer a concern - P2TR addresses can be plainly parsed from the
scriptPubKey
outputs. Updated the PR to addAddress::P2TRv1(tweaked_pub_key)
so taproot addresses can be used throughout the runtime.Closes #606
References
IsWitnessStandard
SignatureHashSchnorr