Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Inconsistent self-redeem logic #1107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Inconsistent self-redeem logic #1107

wants to merge 1 commit into from

Conversation

nakul1010
Copy link
Member

@nakul1010 nakul1010 commented Jun 26, 2023 •
edited
Loading

Closes #1089

ToDos

  • Fix corner case
  • Add Test cases

@nakul1010 nakul1010 requested a review from gregdhill June 26, 2023 10:06
@nakul1010 nakul1010 self-assigned this Jun 26, 2023
@nakul1010 nakul1010 requested a review from sander2 June 26, 2023 10:06
@nakul1010 nakul1010 marked this pull request as draft June 26, 2023 10:07
@nakul1010 nakul1010 added inProgress The PR is still in progress ReviewNeeded The PR can be reviewed by peers and removed inProgress The PR is still in progress labels Jun 26, 2023
@nakul1010 nakul1010 marked this pull request as ready for review June 26, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregdhill gregdhill Awaiting requested review from gregdhill

@sander2 sander2 Awaiting requested review from sander2

At least 1 approving review is required to merge this pull request.

Assignees

@nakul1010 nakul1010

Labels
ReviewNeeded The PR can be reviewed by peers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent self-redeem logic
1 participant
@nakul1010