[NFC][SYCL] Change enqueueImpKernel to return void
#14507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only return `PI_SUCCESS` through normal control flow, all the errors result in an exception thrown. In other words, there is no `return NOT_A_PI_SUCCESS` anyway inside its body, so we can simply make it `void` and simplify its callers.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
llindsaya
approved these changes
Jul 9, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only returns
PI_SUCCESSthrough normal control flow, all the errors result in an exception thrown. In other words, there is noreturn NOT_A_PI_SUCCESSinside its body, so we can simply make itvoidand simplify its callers.