[SYCL][thinLTO] Don't pass -properties and -ir-output-only to sycl-post-link #14501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-link Signed-off-by: Sarnie, Nick <[email protected]>
mdtoguchi
reviewed
Jul 10, 2024
| if (OutputType == types::TY_LLVM_BC) { | ||
| // single file output requested - this means only perform necessary IR | ||
| // transformations (like specialization constant intrinsic lowering) and | ||
| // output LLVMIR | ||
| addArgs(PostLinkArgs, TCArgs, {"-ir-output-only"}); | ||
| } else if (!IsUsingLTO || LTOMode != LTOK_Thin) { | ||
| addArgs(PostLinkArgs, TCArgs, {"-properties"}); |
There was a problem hiding this comment.
Could you add a comment explaining why -properties can't be used along with -ir-output-only? Looks good otherwise.
mdtoguchi
approved these changes
Jul 10, 2024
Signed-off-by: Sarnie, Nick <[email protected]>
|
@asudarsa Ping on this one? This is causing some internal test failures. Thanks! |
asudarsa
reviewed
Jul 10, 2024
|
@intel/llvm-gatekeepers Ready to merge. Thanks |
|
@asudarsa Thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This errors out anyway, so it was just wrong.